VariableAnalysisSniff::processCompactArguments(): fix comment tolerance #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP ignores comments in unexpected/unconventional places and so should the sniff. Includes adjusting an existing unit test. Without the fix, the adjusted unit test would cause test failures.
Collaborator
Author
|
P.S.: after all these, still not finished, but enough for today. More will follow at some point in the future. |
Owner
|
Seriously, this is a lot of work. You're an open source hero. 😁 ❤️ |
jrfnl
deleted the
feature/processcompactarguments-fix-comment-tolerance
branch
Collaborator
Author
|
Thanks and yes, I know 😝 |
sirbrillig
pushed a commit
that referenced
this pull request
May 25, 2020
…ce (#155) PHP ignores comments in unexpected/unconventional places and so should the sniff. Includes adjusting an existing unit test. Without the fix, the adjusted unit test would cause test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP ignores comments in unexpected/unconventional places and so should the sniff.
Includes adjusting an existing unit test.
Without the fix, the adjusted unit test would cause test failures.